handle more nullable types by MikeShi42 · Pull Request #1984 · hyperdxio/hyperdx

MikeShi42 · 2026-03-25T06:47:06Z

Summary

Fix ClickHouse query error when expanding log rows with Nullable(DateTime64) columns (and other Nullable types).

The convertCHDataTypeToJSType function didn't generically unwrap Nullable(...) types, so Nullable(DateTime64(...)) fell through to the default string comparison instead of using parseDateTime64BestEffort()
Added general Nullable(...) recursive unwrapping (matching the existing LowCardinality(...) pattern)
Hoisted null value handling above the type switch in processRowToWhereClause so all column types (Date, Array, Map, etc.) correctly emit isNull() for null values

Screenshots or video

N/A — no UI changes.

How to test locally or on Vercel

Set up a ClickHouse table with a Nullable(DateTime64) column and ingest some rows (including rows with null values in that column).
Open the log explorer and expand a row that has a Nullable(DateTime64) column.
Verify that clicking into the row no longer returns a 400 error.
Verify that clicking into a row where the Nullable(DateTime64) column is null correctly filters using isNull().

References

Related PRs:

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

… (and other misc type) columns.

changeset-bot · 2026-03-25T06:47:11Z

🦋 Changeset detected

Latest commit: 82edb64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@hyperdx/common-utils	Patch
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-03-25T06:47:12Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Apr 2, 2026 6:43am

github-actions · 2026-03-25T06:48:54Z

PR Review

✅ No critical issues found.

The two fixes are correct and follow existing patterns:

Nullable( unwrapping in convertCHDataTypeToJSType mirrors the existing LowCardinality( pattern with correct slice offsets (9 chars)
Null check hoisted above the switch is a clean fix that correctly unifies handling across all types
Tests added for both changes; coverage looks adequate

github-actions · 2026-03-25T06:54:13Z

E2E Test Results

✅ All tests passed • 126 passed • 3 skipped • 1043s

Status	Count
✅ Passed	126
❌ Failed	0
⚠️ Flaky	2
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

MikeShi42 · 2026-03-25T15:22:49Z

@copilot can you pls fix lint errors

Copilot · 2026-03-25T15:25:58Z

@copilot can you pls fix lint errors

Fixed in 877d593 — sorted named imports alphabetically and corrected prettier formatting (double quotes for strings containing single quotes, and .toBe() call placement).

MikeShi42 · 2026-03-25T19:18:56Z

okay @claude maybe you can help me fix this lint issue...

github-actions · 2026-03-25T19:20:09Z

Claude finished @MikeShi42's task in 57s —— View job

Fixed lint issues

Read relevant files
Fix dead code in useRowWhere.tsx — removed unreachable value == null || (null already handled at line 58) and updated stale comment
Remove redundant explicit Nullable(Int/UInt/Float/String) checks in clickhouse/index.ts — superseded by the generic Nullable() unwrapper
Committed and pushed (ede119c5)

MikeShi42 · 2026-03-26T04:55:12Z

AGENTS.md


-**Tools handle formatting and linting automatically** via pre-commit hooks.
-Focus on implementation; don't manually format code.
+**After finishing all code edits**, run `yarn lint:fix` to auto-fix formatting


after losing the war with agents vs linter, I'm telling agents to always lint - I'm not sure why we did not encourage this anyways? @teeohhem maybe you can lmk

We do document the pre-commit hook:

hyperdx/AGENTS.md

Lines 160 to 163 in dea1b66

**Pre-commit hooks must pass before committing.** Do not use `--no-verify` to

skip hooks. If the pre-commit hook fails (e.g. due to husky not being set up in

a worktree), run `npx lint-staged` manually before committing to ensure lint and

formatting checks pass. Fix any issues before creating the commit.

In theory, the agent should ensure the code is formatted before pushing a new commit.

MikeShi42 added 2 commits March 24, 2026 23:45

fix: Fixed bug preventing clicking into rows with nullable date types…

7030cd1

… (and other misc type) columns.

add changeset and tests

efe39e3

MikeShi42 requested review from a team and wrn14897 and removed request for a team March 25, 2026 06:47

MikeShi42 added the automerge label Mar 25, 2026

vercel bot deployed to Preview March 25, 2026 06:49 View deployment

MikeShi42 changed the title ~~Mikeshi/handle more nullable types~~ handle more nullable types Mar 25, 2026

Copilot started work on behalf of MikeShi42 March 25, 2026 15:22 View session

Copilot finished work on behalf of MikeShi42 March 25, 2026 15:26

vercel bot deployed to Preview March 25, 2026 15:29 View deployment

vercel bot deployed to Preview March 25, 2026 19:23 View deployment

vercel bot deployed to Preview March 25, 2026 21:07 View deployment

fix lint, and fix lint forever for agents too

11ee222

MikeShi42 force-pushed the mikeshi/handle-more-nullable-types branch from 9ab50bc to 11ee222 Compare March 26, 2026 04:52

MikeShi42 commented Mar 26, 2026

View reviewed changes

vercel bot deployed to Preview March 26, 2026 04:55 View deployment

wrn14897 approved these changes Apr 2, 2026

View reviewed changes

Merge branch 'main' into mikeshi/handle-more-nullable-types

82edb64

vercel bot deployed to Preview April 2, 2026 06:43 View deployment

kodiakhq bot merged commit 48a8d32 into main Apr 2, 2026
15 of 16 checks passed

kodiakhq bot deleted the mikeshi/handle-more-nullable-types branch April 2, 2026 06:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

handle more nullable types#1984

handle more nullable types#1984
kodiakhq[bot] merged 4 commits intomainfrom
mikeshi/handle-more-nullable-types

MikeShi42 commented Mar 25, 2026 •

edited by Copilot AI

Loading

Uh oh!

changeset-bot bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

MikeShi42 commented Mar 25, 2026

Uh oh!

Copilot AI commented Mar 25, 2026

Uh oh!

MikeShi42 commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

MikeShi42 Mar 26, 2026

Uh oh!

wrn14897 Apr 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	Pre-commit hooks must pass before committing. Do not use `--no-verify` to
	skip hooks. If the pre-commit hook fails (e.g. due to husky not being set up in
	a worktree), run `npx lint-staged` manually before committing to ensure lint and
	formatting checks pass. Fix any issues before creating the commit.

Conversation

MikeShi42 commented Mar 25, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots or video

How to test locally or on Vercel

References

Uh oh!

changeset-bot bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Test Results

Uh oh!

MikeShi42 commented Mar 25, 2026

Uh oh!

Copilot AI commented Mar 25, 2026

Uh oh!

MikeShi42 commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed lint issues

Uh oh!

MikeShi42 Mar 26, 2026

Choose a reason for hiding this comment

Uh oh!

wrn14897 Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MikeShi42 commented Mar 25, 2026 •

edited by Copilot AI

Loading

changeset-bot bot commented Mar 25, 2026 •

edited

Loading

vercel bot commented Mar 25, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading

github-actions bot commented Mar 25, 2026 •

edited

Loading